-
Task
-
Resolution: Fixed
-
Normal
-
None
-
None
-
None
-
Brown Dog - April/May
[11:45 AM] Omar Elabd: Here are the comments
[11:45 AM] Omar Elabd: 1. Combine FileManagerLogs and FileManagerUtility
2. BD_LIb should not be a console application, it should be a library
3. Delete class Program from BD_Lib project
4. If you want to create a test, make a new test project
5. For Console.Writeline you can add a compiler switch, or use a Logging Library such as Log4Net
6. Delete any unnecessary commented out code
7. You can replace explicit creation of threads with Async-Await Tasks ( https://msdn.microsoft.com/en-us/library/system.threading.tasks.paralleloptions.maxdegreeofparalleli... )
8. Investigate: Instead of using JObject use explicit class creation (http://json2csharp.com/), (jsonschema)
9. Replace dynamic whenever you can
10. function DescriptorSetDistance() is only usable on double, you may need to modify if the result is not a double
11. Make sure that variable names aren't one or two letters and that they describe what hte object is
12. Try and split BDUtils class into other smaller classes
13. Exclude any unused code from the project (UpdateMe)
Priority:1. Change Log
1.1. Log4Net or something else
1.2. replace the Console.WriteLine
1.3. Delete old cold
2. Project Structure
2.1. Merge Libraries
2.2. Console to Library
2.3. Unit Test Project
2.4. Delete Main from Program.cs
2.5. Rename Program.cs3. Delete Comments/Unused Files Functions4. Replace dynamic of when you can
4.1. line -> string
4.2. Dictionary . Find(string bdsURL, string queryFilename, string targetDirectory, string token, int wait = 60)
4.3. DenseVector vd1, vd2, vd;