Uploaded image for project: 'Daffodil'
  1. Daffodil
  2. DFDL-1496

Remove withParseErrorThrowing

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Critical Critical
    • 2.0.0
    • None
    • Back End, Performance
    • None

    Description

      And additionally, get rid of cases where we catch ParseErrors. Theoretically, all parsers should just call setFailed if there was an issue, and parses should check pstate.status to see if a child parser failed, and act accordingly. Throwing and Catching parse errors shouldn't really be necessary. We think maybe this was needed for Saxon, but that is gone. Need to determine if anything else actually relies on this behavior.

      Note that in addition to making things more consistent, getting rid of withParseErrorThrowing could maybe have a performance boost, since that actually allocates an anonymous function.

      Gliffy Diagrams

        Attachments

          Activity

            People

              dthompson David Thompson
              slawrence Steve Lawrence
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 2 hours, 6 minutes
                  2h 6m

                  Tasks