Uploaded image for project: 'Daffodil'
  1. Daffodil
  2. DFDL-1737

Consider replacing ByteBufferDataInputStream LongConverter's with getByteArray

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: clean ups
    • Labels:
      None

      Description

      A few reasons why this might be a good idea:

      1. Extra testing of getByteArray, since all getSigned/UnsignedLong would now be using a similar codepath
      2. One place where all the BE/LE/MSBF/LSBF bit twiddling stuff goes, making it easier to optimize in the future
      3. The existing LongConverters have some code that is potentially slow (e.g. reversing bit/byte order of byte buffer, lots of sign extended/unextended, etc.). The getByteArray method is a pretty efficient way to get any amount of bits in to BE MSBF order, which can then be quickly converted to a Long with a few shifts and ors.

        Gliffy Diagrams

          Attachments

            Activity

              People

              Assignee:
              jadams Joshua Adams
              Reporter:
              slawrence Steve Lawrence
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 5 minutes
                  5m

                    Tasks